netdev - Re: [PATCH 22/52] net: e100: remove unnecessary pci_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <000701ceaecc$4655e9c0$d301bd40$%han@samsung.com>
Date:	Wed, 11 Sep 2013 17:52:41 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Jeff Kirsher' <jeffrey.t.kirsher@...el.com>
Cc:	"'David S. Miller'" <davem@...emloft.net>, netdev@...r.kernel.org,
	'Aaron Brown' <aaron.f.brown@...el.com>,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH 22/52] net: e100: remove unnecessary pci_set_drvdata()

On Wednesday, September 11, 2013 5:40 PM, Jeff Kirsher wrote:
> On Wed, 2013-09-11 at 16:45 +0900, Jingoo Han wrote:
> > The driver core clears the driver data to NULL after device_release
> > or on probe failure. Thus, it is not needed to manually clear the
> > device driver data to NULL.
> >
> > Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> > ---
> >  drivers/net/ethernet/intel/e100.c |    2 --
> >  1 file changed, 2 deletions(-)
> 
> While I do not find anything wrong with this patch, I personally like
> good housekeeping so I would like to keep the code as is.  Is there a
> reason for this patch?

Vice versa,
Is there any reason to keep unnecessary code?

Clearing drvdata is done by driver core, so each driver does not
need to clear drvdata.
This patch reduces code size and removes duplicated functional execution.

Please consider it positively. :-)

Best regards,
Jingoo Han


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html