netdev - RE: [PATCH v2 1/1] net: fec: fix phy reset operation to let imx6sl evk work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9848F2DB572E5649BA045B288BE08FBE016D08F1@039-SN2MPN1-023.039d.mgd.msft.net>
Date:	Fri, 13 Sep 2013 01:37:21 +0000
From:	Duan Fugang-B38611 <B38611@...escale.com>
To:	David Miller <davem@...emloft.net>
CC:	"shawn.guo@...aro.org" <shawn.guo@...aro.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"bhutchings@...arflare.com" <bhutchings@...arflare.com>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>,
	Li Frank-B20596 <B20596@...escale.com>,
	"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
Subject: RE: [PATCH v2 1/1] net: fec: fix phy reset operation to let imx6sl
 evk work

From: David Miller [mailto:davem@...emloft.net]
Data: Friday, September 13, 2013 5:13 AM

> To: Duan Fugang-B38611
> Cc: shawn.guo@...aro.org; netdev@...r.kernel.org;
> bhutchings@...arflare.com; stephen@...workplumber.org; Li Frank-B20596;
> s.hauer@...gutronix.de
> Subject: Re: [PATCH v2 1/1] net: fec: fix phy reset operation to let
> imx6sl evk work
> 
> From: Fugang Duan <B38611@...escale.com>
> Date: Wed, 11 Sep 2013 10:18:57 +0800
> 
> > Current driver only do phy reset in probe function, which is not
> > right. Since some phy clock is disabled after module probe, the phy
> > enter abnormal status, which needs do reset to recovery the phy. And
> > do ifconfig ethx up/down test, the phy also enter abnormal status.
> 
> What would disable the PHY clock after the probe?
> 
> You have to explain these kinds of things in your changelog message.
> 
> Thanks.
David,  there have another patch to saving ethernet power, which will disable phy
And MAC clock after module probe. The patch also include the information to explain
Some cases.

Of course, current Linux-next ethernet cannot work for imx6sl evk platform just because the 
Reset operation is not correct, have no dependency on saving power patch. 

Thanks,
Andy

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html