netdev - Re: [PATCH v2 1/1] net: fec: fix phy reset operation to let imx6sl evk work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130912.171251.883636431449078988.davem@davemloft.net>
Date:	Thu, 12 Sep 2013 17:12:51 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	B38611@...escale.com
Cc:	shawn.guo@...aro.org, netdev@...r.kernel.org,
	bhutchings@...arflare.com, stephen@...workplumber.org,
	b20596@...escale.com, s.hauer@...gutronix.de
Subject: Re: [PATCH v2 1/1] net: fec: fix phy reset operation to let imx6sl
 evk work

From: Fugang Duan <B38611@...escale.com>
Date: Wed, 11 Sep 2013 10:18:57 +0800

> Current driver only do phy reset in probe function, which is
> not right. Since some phy clock is disabled after module probe,
> the phy enter abnormal status, which needs do reset to recovery
> the phy. And do ifconfig ethx up/down test, the phy also enter
> abnormal status.

What would disable the PHY clock after the probe?

You have to explain these kinds of things in your changelog
message.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html