netdev - Re: [PATCH] net, vxlan Fix compile warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130913074010.5a778f79@samsung-9>
Date:	Fri, 13 Sep 2013 07:40:10 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Prarit Bhargava <prarit@...hat.com>
Cc:	netdev@...r.kernel.org, jpirko@...hat.com, tgraf@...hat.com,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] net, vxlan Fix compile warning

On Fri, 13 Sep 2013 10:23:51 -0400
Prarit Bhargava <prarit@...hat.com> wrote:

> 
> 
> On 09/13/2013 10:20 AM, Stephen Hemminger wrote:
> > On Fri, 13 Sep 2013 08:29:12 -0400
> > Prarit Bhargava <prarit@...hat.com> wrote:
> > 
> >> Fix a unintialized variable warning.
> >>
> >> drivers/net/vxlan.c: In function ‘vxlan_sock_add’:
> >> drivers/net/vxlan.c:2240:11: error: ‘sock’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> >>   vs->sock = sock;
> >>            ^
> >> drivers/net/vxlan.c:2217:17: note: ‘sock’ was declared here
> >>   struct socket *sock;
> >>                  ^
> >>
> >> Signed-off-by: Prarit Bhargava <prarit@...hat.com>
> >> Cc: jpirko@...hat.com
> >> Cc: tgraf@...hat.com
> >> Cc: "David S. Miller" <davem@...emloft.net>
> > 
> > Which compiler version? Gcc 4.6 is known to be stupid,
> > and I would rather not change the source if it is only caused
> > by a gcc bug fixed in a later release.
> 
> Hi Stephen,
> 
> [root@...el-rosecity-06 ~]# gcc --version
> gcc (GCC) 4.8.1 20130603 (Red Hat 4.8.1-1)
> Copyright (C) 2013 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> 
> P.

Argh, gcc got stupid again. I guess we have to live it.
Acked-by: Stephen Hemminger <stephen@...workplumber.org>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html