netdev - Re: [PATCH] net, vxlan Fix compile warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130916.212358.1356743853860170770.davem@davemloft.net>
Date:	Mon, 16 Sep 2013 21:23:58 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	prarit@...hat.com
Cc:	netdev@...r.kernel.org, jpirko@...hat.com, tgraf@...hat.com
Subject: Re: [PATCH] net, vxlan Fix compile warning

From: Prarit Bhargava <prarit@...hat.com>
Date: Fri, 13 Sep 2013 08:29:12 -0400

> Fix a unintialized variable warning.
> 
> drivers/net/vxlan.c: In function ‘vxlan_sock_add’:
> drivers/net/vxlan.c:2240:11: error: ‘sock’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>   vs->sock = sock;
>            ^
> drivers/net/vxlan.c:2217:17: note: ‘sock’ was declared here
>   struct socket *sock;
>                  ^
> 
> Signed-off-by: Prarit Bhargava <prarit@...hat.com>

Make create_v{4,6}_sock() return an err pointer.

Problem solved and no incredibly ugly, unnecessary, annotations.

The error code return from these functions already gets turned into
and error pointer at the call site, which makes this situation even
more rediculous.