netdev - Re: [PATCH net-next 11/11] sfc: Add static tracepoints to datapath

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1379961289.2485.53.camel@bwh-desktop.uk.level5networks.com>
Date:	Mon, 23 Sep 2013 19:34:49 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	David Miller <davem@...emloft.net>
CC:	<netdev@...r.kernel.org>, <linux-net-drivers@...arflare.com>
Subject: Re: [PATCH net-next 11/11] sfc: Add static tracepoints to datapath

On Mon, 2013-09-23 at 14:17 -0400, David Miller wrote:
> From: Ben Hutchings <bhutchings@...arflare.com>
> Date: Mon, 23 Sep 2013 16:51:07 +0100
> 
> > 2. Generic trace events would be subject to changes that could make them
> > unsuitable for Solarflare's tests.
> 
> This is not an argument for doing things privately in your driver and
> duplicating things.
> 
> We should make a facility that's useful to Solarflare _AS WELL AS_
> everyone else.

OK, I'll try that.

> > 4. Static tracepoints always have run-time overhead, so these should
> > probably be controlled by a kconfig option (as in this patch).
> 
> Don't we use static branches and other tricks to make them close to zero
> overhead?

You're right, it is a static branch if CONFIG_JUMP_LABEL is enabled.
Some documentation has not been updated to reflect this.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html