netdev - Re: [PATCH] net: flow_dissector: fix thoff for IPPROTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52445AD9.9060208@redhat.com>
Date:	Thu, 26 Sep 2013 18:03:37 +0200
From:	Daniel Borkmann <dborkman@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	Nikolay Aleksandrov <nikolay@...hat.com>, netdev@...r.kernel.org,
	davem@...emloft.net, andy@...yhouse.net, fubar@...ibm.com,
	vfalico@...hat.com
Subject: Re: [PATCH] net: flow_dissector: fix thoff for IPPROTO_AH

On 09/26/2013 05:44 PM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
>
> In commit 8ed781668dd49 ("flow_keys: include thoff into flow_keys for
> later usage"), we missed that existing code was using nhoff as a
> temporary variable that could not always contain transport header
> offset.
>
> This is not a problem for TCP/UDP because port offset (@poff)
> is 0 for these protocols.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Daniel Borkmann <dborkman@...hat.com>
> Cc: Nikolay Aleksandrov <nikolay@...hat.com>

Acked-by: Daniel Borkmann <dborkman@...hat.com>

Thanks !

> ---
>   net/core/flow_dissector.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
> index 1929af8..8d7d0dd 100644
> --- a/net/core/flow_dissector.c
> +++ b/net/core/flow_dissector.c
> @@ -154,8 +154,8 @@ ipv6:
>   	if (poff >= 0) {
>   		__be32 *ports, _ports;
>
> -		nhoff += poff;
> -		ports = skb_header_pointer(skb, nhoff, sizeof(_ports), &_ports);
> +		ports = skb_header_pointer(skb, nhoff + poff,
> +					   sizeof(_ports), &_ports);
>   		if (ports)
>   			flow->ports = *ports;
>   	}
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html