netdev - Re: [PATCH] net: flow_dissector: fix thoff for IPPROTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1380211524.3165.192.camel@edumazet-glaptop>
Date:	Thu, 26 Sep 2013 09:05:24 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Nikolay Aleksandrov <nikolay@...hat.com>
Cc:	Daniel Borkmann <dborkman@...hat.com>, netdev@...r.kernel.org,
	davem@...emloft.net, andy@...yhouse.net, fubar@...ibm.com,
	vfalico@...hat.com
Subject: Re: [PATCH] net: flow_dissector: fix thoff for IPPROTO_AH

On Thu, 2013-09-26 at 17:48 +0200, Nikolay Aleksandrov wrote:

> 
> 1 question about my current patchset, can I leave it to get reviewed and if
> applied to post a follow-up for net-next that fixes the issue, or would you
> prefer a v4 that integrates the fix ?

I think your 1/3 patch only has to pass nhoff as value instead of
reference.

+__be32 skb_flow_get_ports(const struct sk_buff *skb, int thoff, u8 ip_proto)
+{
+       int poff = proto_ports_offset(ip_proto);
+
+       if (poff >= 0) {
+               __be32 *ports, _ports;
+
+               ports = skb_header_pointer(skb, thoff + poff,
+					   sizeof(_ports), &_ports);
+               if (ports)
+                       return *ports;
+       }
+
+       return 0;
+}



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html