netdev - Re: [PATCH v1] USBNET: fix handling padding packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 28 Sep 2013 07:51:32 +0800
From:	Ming Lei <ming.lei@...onical.com>
To:	"David S. Miller" <davem@...emloft.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Oliver Neukum <oneukum@...e.de>,
	Network Development <netdev@...r.kernel.org>,
	linux-usb <linux-usb@...r.kernel.org>,
	Ming Lei <ming.lei@...onical.com>
Subject: Re: [PATCH v1] USBNET: fix handling padding packet

On Mon, Sep 23, 2013 at 8:59 PM, Ming Lei <ming.lei@...onical.com> wrote:
> Commit 638c5115a7949(USBNET: support DMA SG) introduces DMA SG
> if the usb host controller is capable of building packet from
> discontinuous buffers, but missed handling padding packet when
> building DMA SG.
>
> This patch attachs the pre-allocated padding packet at the
> end of the sg list, so padding packet can be sent to device
> if drivers require that.
>
> Reported-by: David Laight <David.Laight@...lab.com>
> Acked-by: Oliver Neukum <oliver@...kum.org>
> Signed-off-by: Ming Lei <ming.lei@...onical.com>
> ---
> v1:
>         - fix bug in case of dev->can_dma_sg and !urb->num_sgs

David, could you queue this patch in your tree? And it should fix
regression caused by commit 638c5115a7949(USBNET: support
DMA SG), since I found that without the padding the device can't
send out packets successfully if their length is dividable by max
packet size, and the problem can be observed with icmp sending:

 $ping -s 974 another_machine  #from host with ax99179_178a attached


Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html