netdev - Re: [PATCH v1] USBNET: fix handling padding packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130928.154541.1873056783751780882.davem@davemloft.net>
Date:	Sat, 28 Sep 2013 15:45:41 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ming.lei@...onical.com
Cc:	gregkh@...uxfoundation.org, oneukum@...e.de,
	netdev@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v1] USBNET: fix handling padding packet

From: Ming Lei <ming.lei@...onical.com>
Date: Mon, 23 Sep 2013 20:59:35 +0800

> Commit 638c5115a7949(USBNET: support DMA SG) introduces DMA SG
> if the usb host controller is capable of building packet from
> discontinuous buffers, but missed handling padding packet when
> building DMA SG.
> 
> This patch attachs the pre-allocated padding packet at the
> end of the sg list, so padding packet can be sent to device
> if drivers require that.
> 
> Reported-by: David Laight <David.Laight@...lab.com>
> Acked-by: Oliver Neukum <oliver@...kum.org>
> Signed-off-by: Ming Lei <ming.lei@...onical.com>

Applied, thanks.

I still think the suggestion to disable scatter gather for
devices with the padding issue was the most sane approach
to solve this.

I guess people like supporting complicated crap and excess
code for things that pretty much do not exist, or at best
are not prominent enough to cater for at all.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html