lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 27 Sep 2013 02:15:41 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: Ingo Molnar <mingo@...nel.org> Cc: John Stultz <john.stultz@...aro.org>, LKML <linux-kernel@...r.kernel.org>, Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>, Mirko Lindner <mlindner@...vell.com>, Stephen Hemminger <stephen@...workplumber.org>, Roger Luethi <rl@...lgate.ch>, Patrick McHardy <kaber@...sh.net>, Rusty Russell <rusty@...tcorp.com.au>, "Michael S. Tsirkin" <mst@...hat.com>, Alexey Kuznetsov <kuznet@....inr.ac.ru>, James Morris <jmorris@...ei.org>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, Wensong Zhang <wensong@...ux-vs.org>, Simon Horman <horms@...ge.net.au>, Julian Anastasov <ja@....bg>, Jesse Gross <jesse@...ira.com>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, Steven Rostedt <rostedt@...dmis.org>, Peter Zijlstra <peterz@...radead.org>, Thomas Gleixner <tglx@...utronix.de>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, netfilter-devel@...r.kernel.org Subject: Re: [PATCH 1/4] [RFC] net: Explicitly initialize u64_stats_sync structures for lockdep On Fri, 2013-09-27 at 07:44 +0200, Ingo Molnar wrote: > C cannot pass along symbolic names, unfortunately, so we are stuck with > 1970's tech and the C preprocessor. > Yes, I realized that a bit too late. > There's a way to make such macros look a tiny bit more structured and thus > be more palatable: > > #if BITS_PER_LONG == 32 && defined(CONFIG_SMP) > # define u64_stats_init(syncp) seqcount_init(syncp.seq) > #else > # define u64_stats_init(syncp) > #endif > > Note, the 'else' branch should probably be: > > # define u64_stats_init(syncp) do { } while (0) Yes, this is better ;) Thanks ! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists