netdev - Re: [PATCH net-next 1/5] tipc: silence sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52455471.8060102@windriver.com>
Date:	Fri, 27 Sep 2013 17:48:33 +0800
From:	Ying Xue <ying.xue@...driver.com>
To:	Andreas Bofjäll <andreas.bofjall@...csson.com>
CC:	David Miller <davem@...emloft.net>, <jon.maloy@...csson.com>,
	<netdev@...r.kernel.org>, <paul.gortmaker@...driver.com>,
	<erik.hugne@...csson.com>, <maloy@...jonn.com>,
	<tipc-discussion@...ts.sourceforge.net>
Subject: Re: [PATCH net-next 1/5] tipc: silence sparse warnings

On 09/27/2013 04:15 PM, Andreas Bofjäll wrote:
> On 09/27/2013 10:01 AM, Ying Xue wrote:
>> Good point!
>> It's better for us to use memcpy_fromiovecend() instead of
>> skb_copy_to_linear_data() and its friends.
>>
>> We will submit another version to correct this error soon.
> 
> I could be wrong here, but I think you should also remove the entire
> cast on line 1210 in link.c:
> 
> sect_crs = msg_sect[curr_sect].iov_base;
> 
> There should be no reason to cast there since you made sect_crs into
> const unchar* __user and msg_sect[].iov_base is void* __user.
> 

You are right, thank you for your nice reminder!

Regards,
Ying

> /Andreas
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html