lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 27 Sep 2013 06:25:07 -0400 From: Jon Maloy <maloy@...jonn.com> To: Ying Xue <ying.xue@...driver.com> CC: Andreas Bofjäll <andreas.bofjall@...csson.com>, jon.maloy@...csson.com, netdev@...r.kernel.org, paul.gortmaker@...driver.com, erik.hugne@...csson.com, tipc-discussion@...ts.sourceforge.net Subject: Re: [PATCH net-next 1/5] tipc: silence sparse warnings On 09/27/2013 05:48 AM, Ying Xue wrote: > On 09/27/2013 04:15 PM, Andreas Bofjäll wrote: >> On 09/27/2013 10:01 AM, Ying Xue wrote: >>> Good point! >>> It's better for us to use memcpy_fromiovecend() instead of >>> skb_copy_to_linear_data() and its friends. >>> >>> We will submit another version to correct this error soon. Can you fix this asap, so I can re-post it? And, let's continue the thread in tipc-discussion only until we (incl Paul) are happy with this patch. ///jon >> I could be wrong here, but I think you should also remove the entire >> cast on line 1210 in link.c: >> >> sect_crs = msg_sect[curr_sect].iov_base; >> >> There should be no reason to cast there since you made sect_crs into >> const unchar* __user and msg_sect[].iov_base is void* __user. >> > You are right, thank you for your nice reminder! > > Regards, > Ying > >> /Andreas >> >> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists