netdev - Re: [PATCH] moxa: drop free_irq of devm_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130930.145526.2002275544537353463.davem@davemloft.net>
Date:	Mon, 30 Sep 2013 14:55:26 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	weiyj.lk@...il.com
Cc:	grant.likely@...aro.org, rob.herring@...xeda.com,
	jg1.han@...sung.com, jonas.jensen@...il.com,
	yongjun_wei@...ndmicro.com.cn, netdev@...r.kernel.org
Subject: Re: [PATCH] moxa: drop free_irq of devm_request_irq allocated irq

From: Wei Yongjun <weiyj.lk@...il.com>
Date: Wed, 25 Sep 2013 15:33:29 +0800

> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> irq allocated with devm_request_irq should not be freed using
> free_irq, because doing so causes a dangling pointer, and a
> subsequent double free.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

I think this is a dangerous change, if the IRQ fires after the point
of the existing free_irq() call it will try to dereference the net
device struct which will be free by the time the devm release code
runes.

I'm not applying this patch, sorry.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html