netdev - Re: [PATCH 2/2] net: qmi_wwan: fix checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130930.150009.1201441098562675548.davem@davemloft.net>
Date:	Mon, 30 Sep 2013 15:00:09 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bjorn@...k.no
Cc:	fabio.porcedda@...il.com, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org, dcbw@...hat.com
Subject: Re: [PATCH 2/2] net: qmi_wwan: fix checkpatch warnings

From: Bjørn Mork <bjorn@...k.no>
Date: Wed, 25 Sep 2013 15:31:39 +0200

> Sorry, I really don't see the point of this.  Yes, the lines are longer
> than 80 columns, but breaking them don't improve the readability at
> all.  On the contrary, IMHO.
> 
> So NAK from me for this part.

Sorry, breaking things up like this is what we do everywhere.

It's not strictly 80 columns but "about 80 columns".

And the only place we don't break things up is for messages that end
up in the kernel log.  Those strings can take the line as long as is
reasonably necessary.

But at argument delimiters and operators for long complex expressions,
we break it up so that the lines do not significantly exceed 80
columns.

Anything else is your opinion, and not what we've been trying to do
consistently across the kernel and in particular in the networking.

Therefore this patch is perfectly fine and I intent to apply it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html