netdev - Re: [PATCH] ip: make -resolve addr to print names rather than addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131004112530.1cab081c@nehalam.linuxnetplumber.net>
Date:	Fri, 4 Oct 2013 11:25:30 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Sami Kerola <kerolasa@....fi>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ip: make -resolve addr to print names rather than
 addresses

On Mon, 30 Sep 2013 22:01:48 +0100
Sami Kerola <kerolasa@....fi> wrote:

> As a system admin I occasionally want to be able to check that all
> interfaces has a name in DNS or /etc/hosts file.
> 
> Signed-off-by: Sami Kerola <kerolasa@....fi>
> ---
>  ip/ipaddress.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/ip/ipaddress.c b/ip/ipaddress.c
> index 1c3e4da..d02eaaf 100644
> --- a/ip/ipaddress.c
> +++ b/ip/ipaddress.c
> @@ -636,7 +636,7 @@ int print_addrinfo(const struct sockaddr_nl *who, struct nlmsghdr *n,
>  		fprintf(fp, "    family %d ", ifa->ifa_family);
>  
>  	if (rta_tb[IFA_LOCAL]) {
> -		fprintf(fp, "%s", rt_addr_n2a(ifa->ifa_family,
> +		fprintf(fp, "%s", format_host(ifa->ifa_family,
>  					      RTA_PAYLOAD(rta_tb[IFA_LOCAL]),
>  					      RTA_DATA(rta_tb[IFA_LOCAL]),
>  					      abuf, sizeof(abuf)));
> @@ -647,7 +647,7 @@ int print_addrinfo(const struct sockaddr_nl *who, struct nlmsghdr *n,
>  			fprintf(fp, "/%d ", ifa->ifa_prefixlen);
>  		} else {
>  			fprintf(fp, " peer %s/%d ",
> -				rt_addr_n2a(ifa->ifa_family,
> +				format_host(ifa->ifa_family,
>  					    RTA_PAYLOAD(rta_tb[IFA_ADDRESS]),
>  					    RTA_DATA(rta_tb[IFA_ADDRESS]),
>  					    abuf, sizeof(abuf)),
> @@ -657,14 +657,14 @@ int print_addrinfo(const struct sockaddr_nl *who, struct nlmsghdr *n,
>  
>  	if (rta_tb[IFA_BROADCAST]) {
>  		fprintf(fp, "brd %s ",
> -			rt_addr_n2a(ifa->ifa_family,
> +			format_host(ifa->ifa_family,
>  				    RTA_PAYLOAD(rta_tb[IFA_BROADCAST]),
>  				    RTA_DATA(rta_tb[IFA_BROADCAST]),
>  				    abuf, sizeof(abuf)));
>  	}
>  	if (rta_tb[IFA_ANYCAST]) {
>  		fprintf(fp, "any %s ",
> -			rt_addr_n2a(ifa->ifa_family,
> +			format_host(ifa->ifa_family,
>  				    RTA_PAYLOAD(rta_tb[IFA_ANYCAST]),
>  				    RTA_DATA(rta_tb[IFA_ANYCAST]),
>  				    abuf, sizeof(abuf)));

This shouldn't be the default. It will change the result that user's expect now.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html