netdev - Re: [PATCH net-next 01/10] qlcnic: Print informational messages only once during driver load.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131004142938.4ab6c6aa@nehalam.linuxnetplumber.net>
Date:	Fri, 4 Oct 2013 14:29:38 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Himanshu Madhani <himanshu.madhani@...gic.com>
Cc:	<davem@...emloft.net>, <netdev@...r.kernel.org>,
	<Dept_NX_Linux_NIC_Driver@...gic.com>,
	Sucheta Chakraborty <sucheta.chakraborty@...gic.com>
Subject: Re: [PATCH net-next 01/10] qlcnic: Print informational messages
 only once during driver load.

On Fri, 4 Oct 2013 14:30:48 -0400
Himanshu Madhani <himanshu.madhani@...gic.com> wrote:

> From: Sucheta Chakraborty <sucheta.chakraborty@...gic.com>
> 
> Signed-off-by: Sucheta Chakraborty <sucheta.chakraborty@...gic.com>
> Signed-off-by: Himanshu Madhani <himanshu.madhani@...gic.com>
> ---
>  drivers/net/ethernet/qlogic/qlcnic/qlcnic.h        |  1 +
>  .../net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c    | 12 -----------
>  .../net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c  | 25 ++++++++++++++++++----
>  drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c   |  1 +
>  4 files changed, 23 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
> index 81bf836..a3c4379 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
> @@ -1199,6 +1199,7 @@ struct qlcnic_npar_info {
>  	u8	promisc_mode;
>  	u8	offload_flags;
>  	u8      pci_func;
> +	u8      mac[ETH_ALEN];
>  };
>  

>  

There is a field in netdevice which should probably be used for this perm_addr.

And then this could be corrected:

static void qlcnic_dcb_get_perm_hw_addr(struct net_device *netdev, u8 *addr)
{
	memcpy(addr, netdev->dev_addr, netdev->addr_len);
}

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html