netdev - RE: [PATCH net-next 02/10] qlcnic: Enhance ethtool to display ring indices and interrupt mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ADFE82A996F10145934E45547759F7638C91F870@avmb3.qlogic.org>
Date:	Fri, 4 Oct 2013 22:21:21 +0000
From:	Himanshu Madhani <himanshu.madhani@...gic.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Dept-NX Linux NIC Driver 
	<Dept_NX_Linux_NIC_Driver@...gic.com>
Subject: RE: [PATCH net-next 02/10] qlcnic: Enhance ethtool to display ring
 indices and interrupt mask

> 
> This is really sad; why don't you write a proper dump parser for ethtool
> rather than including markers that make it slightly easier to read hex
> dumps?
> 
> And when changing the dump format in an incompatible way like this, you
> should also bump the version number.
> 

We will resubmit the patch after making the appropriate changes.

> Ben.
> 
> --
> Ben Hutchings, Staff Engineer, Solarflare
> Not speaking for my employer; that's the marketing department's job.
> They asked us to note that Solarflare product names are trademarked.