netdev - Re: [PATCH] tcp: do not forget FIN in tcp_shifted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131004.141735.1539840568193384153.davem@davemloft.net>
Date:	Fri, 04 Oct 2013 14:17:35 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ilpo.jarvinen@...sinki.fi
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org,
	ncardwell@...gle.com, ycheng@...gle.com
Subject: Re: [PATCH] tcp: do not forget FIN in tcp_shifted_skb()

From: "Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
Date: Fri, 4 Oct 2013 21:03:53 +0300 (EEST)

> On Fri, 4 Oct 2013, Eric Dumazet wrote:
> 
>> From: Eric Dumazet <edumazet@...gle.com>
>> 
>> Yuchung found following problem :
>> 
>>  There are bugs in the SACK processing code, merging part in
>>  tcp_shift_skb_data(), that incorrectly resets or ignores the sacked
>>  skbs FIN flag. When a receiver first SACK the FIN sequence, and later
>>  throw away ofo queue (e.g., sack-reneging), the sender will stop
>>  retransmitting the FIN flag, and hangs forever.
>> 
>> Following packetdrill test can be used to reproduce the bug.
 ...
> Nice that it was finally found. For some reason my memory tries to say 
> that it wouldn't have not even tried to merge skbs with FIN but either
> I changed that at some point while deving or I just remember wrong.
> 
> Acked-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html