netdev - [PATCH] wimax: Use WARN(1,...) rather than printk followed by WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1381192238-6486-1-git-send-email-duanj.fnst@cn.fujitsu.com>
Date:	Mon,  7 Oct 2013 17:30:38 -0700
From:	djduanjiong@...il.com
To:	Inaky Perez-Gonzalez <inaky.perez-gonzalez@...el.com>,
	"David S. Miller" <davem@...emloft.net>, linux-wimax@...el.com
Cc:	wimax@...uxwimax.org, netdev@...r.kernel.org,
	Duan Jiong <duanj.fnst@...fujitsu.com>
Subject: [PATCH] wimax: Use WARN(1,...) rather than printk followed by WARN_ON(1)

From: Duan Jiong <duanj.fnst@...fujitsu.com>

Signed-off-by: Duan Jiong <duanj.fnst@...fujitsu.com>
---
 net/wimax/id-table.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/net/wimax/id-table.c b/net/wimax/id-table.c
index 72273ab..635a4d2 100644
--- a/net/wimax/id-table.c
+++ b/net/wimax/id-table.c
@@ -136,10 +136,8 @@ void wimax_id_table_release(void)
 	return;
 #endif
 	spin_lock(&wimax_id_table_lock);
-	list_for_each_entry(wimax_dev, &wimax_id_table, id_table_node) {
-		printk(KERN_ERR "BUG: %s wimax_dev %p ifindex %d not cleared\n",
+	list_for_each_entry(wimax_dev, &wimax_id_table, id_table_node)
+		WARN(1, KERN_ERR "BUG: %s wimax_dev %p ifindex %d not cleared\n",
 		       __func__, wimax_dev, wimax_dev->net_dev->ifindex);
-		WARN_ON(1);
-	}
 	spin_unlock(&wimax_id_table_lock);
 }
-- 
1.7.7.6

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html