netdev - Re: [PATCH] wimax: Use WARN(1,...) rather than printk followed by WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131011.143823.1482605672848878474.davem@davemloft.net>
Date:	Fri, 11 Oct 2013 14:38:23 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	djduanjiong@...il.com
Cc:	inaky.perez-gonzalez@...el.com, linux-wimax@...el.com,
	wimax@...uxwimax.org, netdev@...r.kernel.org,
	duanj.fnst@...fujitsu.com
Subject: Re: [PATCH] wimax: Use WARN(1,...) rather than printk followed by
 WARN_ON(1)

From: djduanjiong@...il.com
Date: Mon,  7 Oct 2013 17:30:38 -0700

> -	list_for_each_entry(wimax_dev, &wimax_id_table, id_table_node) {
> -		printk(KERN_ERR "BUG: %s wimax_dev %p ifindex %d not cleared\n",
> +	list_for_each_entry(wimax_dev, &wimax_id_table, id_table_node)
> +		WARN(1, KERN_ERR "BUG: %s wimax_dev %p ifindex %d not cleared\n",
>  		       __func__, wimax_dev, wimax_dev->net_dev->ifindex);


You are changing the column where the openning parenthesis appears by
changing the printk() into a WARN(), therefore you have to adjust the
indentation of the next line such that the arguments start at the first
column after the openning parenthesis.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html