netdev - Re: [PATCH] net: sh_eth: Fix RX packets errors on R8A7740

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Oct 2013 14:29:33 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Nguyen Hong Ky <nh-ky@...so.co.jp>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Ryusuke Sakato <ryusuke.sakato.bx@...esas.com>,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Subject: Re: [PATCH] net: sh_eth: Fix RX packets errors on R8A7740

On Wed, Oct 09, 2013 at 02:38:17PM +0900, Nguyen Hong Ky wrote:
> On Wed, Oct 9, 2013 at 2:26 PM, Simon Horman <horms@...ge.net.au> wrote:
> > On Wed, Oct 09, 2013 at 01:28:26PM +0900, Simon Horman wrote:
> >> On Mon, Oct 07, 2013 at 03:29:25PM +0900, Nguyen Hong Ky wrote:
> >> > This patch will fix RX packets errors when receiving big size
> >> > of data by set bit RNC = 1.
> >> >
> >> > RNC - Receive Enable Control
> >> >
> >> > 0: Upon completion of reception of one frame, the E-DMAC writes
> >> > the receive status to the descriptor and clears the RR bit in
> >> > EDRRR to 0.
> >> >
> >> > 1: Upon completion of reception of one frame, the E-DMAC writes
> >> > (writes back) the receive status to the descriptor. In addition,
> >> > the E-DMAC reads the next descriptor and prepares for reception
> >> > of the next frame.
> >> >
> >> > In addition, for get more stable when receiving packets, I set
> >> > maximum size for the transmit/receive FIFO and inserts padding
> >> > in receive data.
> >> >
> >> > Signed-off-by: Nguyen Hong Ky <nh-ky@...so.co.jp>
> >>
> >> I realise that this patch has been applied but regardless
> >> I would like to acknowledge that it resolve a problem that
> >> I observed this afternoon.
> >>
> >> Without this patch I see the following on the console, many times:
> >>
> >> net eth0: Receive FIFO Overflow
> >>
> >> With this patch I do not see the warning message at all.
> >
> > Scratch that, I am still seeing the messages with this patch applied.
> >
> 
> Would you please confirm that it was patched in below function:
> 
> static struct sh_eth_cpu_data r8a7740_data = {...}

Thanks Ky-san.

I am seeing the problem on next-next
ba53742 ("tcp: use ACCESS_ONCE() in tcp_update_pacing_rate()")
which includes this patch.

However, it seems that the patch was applied to
sh7734_data instead of r8a7740_data.

I moved the changes from sh7734_data to r8a7740_data
and the FIFO Overflow messages seem to have disappeared.

I will post a patch to move things around accordingly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html