netdev - Re: [PATCH] net: sh_eth: Fix RX packets errors on R8A7740

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52597FC0.4090801@cogentembedded.com>
Date:	Sat, 12 Oct 2013 18:58:40 +0200
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Guennadi Liakhovetski <g.liakhovetski@....de>
CC:	Nguyen Hong Ky <nh-ky@...so.co.jp>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Ryusuke Sakato <ryusuke.sakato.bx@...esas.com>,
	Simon Horman <horms@...ge.net.au>
Subject: Re: [PATCH] net: sh_eth: Fix RX packets errors on R8A7740

Hello.

On 07-10-2013 8:29, Nguyen Hong Ky wrote:

> This patch will fix RX packets errors when receiving big size
> of data by set bit RNC = 1.

> RNC - Receive Enable Control

> 0: Upon completion of reception of one frame, the E-DMAC writes
> the receive status to the descriptor and clears the RR bit in
> EDRRR to 0.

> 1: Upon completion of reception of one frame, the E-DMAC writes
> (writes back) the receive status to the descriptor. In addition,
> the E-DMAC reads the next descriptor and prepares for reception
> of the next frame.

> In addition, for get more stable when receiving packets, I set
> maximum size for the transmit/receive FIFO and inserts padding
> in receive data.

> Signed-off-by: Nguyen Hong Ky <nh-ky@...so.co.jp>
> ---
>   drivers/net/ethernet/renesas/sh_eth.c |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)

> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index a753928..11d34f0 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -649,12 +649,16 @@ static struct sh_eth_cpu_data r8a7740_data = {
>   	.eesr_err_check	= EESR_TWB1 | EESR_TWB | EESR_TABT | EESR_RABT |
>   			  EESR_RFE | EESR_RDE | EESR_RFRMER | EESR_TFE |
>   			  EESR_TDE | EESR_ECI,
> +	.fdr_value	= 0x0000070f,
> +	.rmcr_value	= 0x00000001,
>
>   	.apr		= 1,
>   	.mpr		= 1,
>   	.tpauser	= 1,
>   	.bculr		= 1,
>   	.hw_swap	= 1,
> +	.rpadir		= 1,
> +	.rpadir_value   = 2 << 16,
>   	.no_trimd	= 1,
>   	.no_ade		= 1,
>   	.tsu		= 1,

    Guennadi, could you check if this patch fixes your issue with NFS. Make 
sure it applies to 'r8a7740_data' (it was misapplied to DaveM's tree).

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html