netdev - Re: [PATCH 1/9 RESENT] staging: r8188eu: Set device type to wlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5261AF11.2090004@cogentembedded.com>
Date:	Sat, 19 Oct 2013 01:58:41 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Larry Finger <Larry.Finger@...inger.net>,
	gregkh@...uxfoundation.org
CC:	netdev <netdev@...r.kernel.org>, devel@...verdev.osuosl.org
Subject: Re: [PATCH 1/9 RESENT] staging: r8188eu: Set device type to wlan

Hello.

On 10/19/2013 01:32 AM, Larry Finger wrote:

> The latest version of NetworkManager does not recognize the device as wireless
> without this change.

> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
> ---
>   drivers/staging/rtl8188eu/os_dep/os_intfs.c | 5 +++++
>   1 file changed, 5 insertions(+)

> diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
> b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
> index da9f0d5..17659bb 100644
> --- a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
> @@ -707,6 +707,10 @@ int rtw_init_netdev_name(struct net_device *pnetdev,
> const char *ifname)
>       return 0;
>   }
>   +static const struct device_type wlan_type = {

    Hm, a space got added before +, so the patch was somehow broken.

> +    .name = "wlan",
> +};
> +
>   struct net_device *rtw_init_netdev(struct adapter *old_padapter)
>   {
>       struct adapter *padapter;
> @@ -722,6 +726,7 @@ struct net_device *rtw_init_netdev(struct adapter
> *old_padapter)
>       if (!pnetdev)
>           return NULL;
>   +    pnetdev->dev.type = &wlan_type;

    Here too.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html