netdev - Re: [PATCH 2/9 RESENT] staging: r8188eu: Fix Sparse warnings in rtw_wlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1382133902.3381.23.camel@bwh-desktop.uk.level5networks.com>
Date:	Fri, 18 Oct 2013 23:05:02 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Larry Finger <Larry.Finger@...inger.net>
CC:	<gregkh@...uxfoundation.org>, netdev <netdev@...r.kernel.org>,
	<devel@...verdev.osuosl.org>
Subject: Re: [PATCH 2/9 RESENT] staging: r8188eu: Fix Sparse warnings in
 rtw_wlan_util

On Fri, 2013-10-18 at 16:33 -0500, Larry Finger wrote:
> Sparse shows the following warning:
> 
>    CHECK   drivers/staging/rtl8188eu/core/rtw_wlan_util.c
> drivers/staging/rtl8188eu/core/rtw_wlan_util.c:1635:25: warning: cast to 
> restricted __le16
> 
> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
> ---
>   drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c 
> b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
> index 153ec61..30ba18c 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
> @@ -1632,7 +1632,7 @@ void process_addba_req(struct adapter *padapter, u8 
> *paddba_req, u8 *addr)
>   	psta = rtw_get_stainfo(pstapriv, addr);
>    	if (psta) {
> -		param = le16_to_cpu(preq->BA_para_set);
> +		param = preq->BA_para_set;

preq is pointing to a header which has fixed byte order on the wire, so
this field presumably really is little-endian and the struct definition
should be changed.

Comapre the various headers in drivers/staging/rtl8188eu/include/wifi.h
with struct ieee80211_mgmt in include/linux/ieee80211.h.

Ben.

>   		tid = (param>>2)&0x0f;
>   		preorder_ctrl = &psta->recvreorder_ctrl[tid];
>   		preorder_ctrl->indicate_seq = 0xffff;

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html