netdev - Re: [PATCH 3/9 RESENT] staging: r8188eu: Fix sparse warnings in ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1382134111.3381.25.camel@bwh-desktop.uk.level5networks.com>
Date:	Fri, 18 Oct 2013 23:08:31 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Larry Finger <Larry.Finger@...inger.net>
CC:	<gregkh@...uxfoundation.org>, <netdev@...r.kernel.org>,
	<devel@...verdev.osuosl.org>
Subject: Re: [PATCH 3/9 RESENT] staging: r8188eu: Fix sparse warnings in
 ioctl_linux.c

On Fri, 2013-10-18 at 16:34 -0500, Larry Finger wrote:
> Sparse checking results in the following warnings:
> 
>    CHECK   drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
> drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3932:17: warning: cast removes 
> address space of expression
> drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3933:31: warning: incorrect type 
> in argument 1 (different address spaces)
[...]
> -		DBG_88E("[%s] extra = %s\n", __func__, (char *)wrqu->data.pointer);
> -	if (!memcmp(wrqu->data.pointer, "status", 6)) {
> +		DBG_88E("[%s] extra = %s\n", __func__, (__force char *)wrqu->data.pointer);
> +	if (!memcmp((__force const char *)wrqu->data.pointer, "status", 6)) {
[...]

This is hiding the problem, not fixing it.

This private interface needs to be removed anyway.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html