netdev - Re: [PATCH net-next 5/5] 6lowpan: remove unecessary break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131024.234218.106475949731790312.davem@davemloft.net>
Date:	Thu, 24 Oct 2013 23:42:18 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	alex.bluesman.smirnov@...il.com, alex.aring@...il.com,
	linux-zigbee-devel@...ts.sourceforge.net, werner@...esberger.net,
	dbaryshkov@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 5/5] 6lowpan: remove unecessary break

From: Joe Perches <joe@...ches.com>
Date: Thu, 24 Oct 2013 20:40:51 -0700

> On Fri, 2013-10-25 at 07:28 +0400, Alexander Smirnov wrote:
>> > 25 окт. 2013 г., в 0:51, Alexander Aring <alex.aring@...il.com> написал(а):
> []
>> > diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
> []
>> > @@ -440,7 +440,6 @@ lowpan_uncompress_udp_header(struct sk_buff *skb, struct udphdr *uh)
>> >        default:
>> >            pr_debug("ERROR: unknown UDP format\n");
>> >            goto err;
>> > -            break;
>> >        }
>> > 
>> 
>> It's not an unnecessary, it's let say a "good coding practice" to have a break for every case including default. 
> 
> Hello Alexanders:
> 
> Some would otherwise say it's a poor practice.

I think with a goto there at the end of the case statement, it's redundant
and stupid, and thus should be removed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html