netdev - Re: [PATCH net-next 5/5] 6lowpan: remove unecessary break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <526A6CB2.1040007@cogentembedded.com>
Date:	Fri, 25 Oct 2013 17:05:54 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Alexander Smirnov <alex.bluesman.smirnov@...il.com>,
	Alexander Aring <alex.aring@...il.com>
CC:	"linux-zigbee-devel@...ts.sourceforge.net" 
	<linux-zigbee-devel@...ts.sourceforge.net>,
	"werner@...esberger.net" <werner@...esberger.net>,
	"dbaryshkov@...il.com" <dbaryshkov@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 5/5] 6lowpan: remove unecessary break

Hello.

On 25-10-2013 7:28, Alexander Smirnov wrote:

>> Signed-off-by: Alexander Aring <alex.aring@...il.com>
>> Reviewed-by: Werner Almesberger <werner@...esberger.net>
>> ---
>> net/ieee802154/6lowpan.c | 1 -
>> 1 file changed, 1 deletion(-)

>> diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
>> index e15b101..09350f1 100644
>> --- a/net/ieee802154/6lowpan.c
>> +++ b/net/ieee802154/6lowpan.c
>> @@ -440,7 +440,6 @@ lowpan_uncompress_udp_header(struct sk_buff *skb, struct udphdr *uh)
>>         default:
>>             pr_debug("ERROR: unknown UDP format\n");
>>             goto err;
>> -            break;
>>         }

> It's not an unnecessary, it's let say a "good coding practice" to have a break for every case including default.

    Even after *goto*? :-)

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html