netdev - Re: [PATCH] ibm emac: Don't call napi_complete if napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131025.191301.1496864269923138314.davem@davemloft.net>
Date:	Fri, 25 Oct 2013 19:13:01 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	alistair@...ple.id.au
Cc:	netdev@...r.kernel.org, benh@...nel.crashing.org
Subject: Re: [PATCH] ibm emac: Don't call napi_complete if napi_reschedule
 failed

From: Alistair Popple <alistair@...ple.id.au>
Date: Thu, 24 Oct 2013 14:36:20 +1100

> This patch fixes a bug which would trigger the BUG_ON() at
> net/core/dev.c:4156. It was found that this was due to napi_complete
> being called even when the corresponding call to napi_reschedule had
> failed.
> 
> This patch ensures that we only contine processing rotting packets in
> the current mal_poll call if we are not already on the polling list.
> It also adds locking calls to protect the read-write-modify of the
> MAL_CFG DCR.
> 
> Signed-off-by: Alistair Popple <alistair@...ple.id.au>

The mistaken napi_complete() call and the locking change are two different
bugs, fix them in two different patches.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html