lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 Oct 2013 16:25:02 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: Alexei Starovoitov <ast@...mgrid.com> Cc: David Miller <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, stephen@...workplumber.org, netdev@...r.kernel.org Subject: Re: vxlan gso is broken by stackable gso_segment() On Fri, 2013-10-25 at 15:41 -0700, Alexei Starovoitov wrote: > 'bool tunnel' actually still used to indicate encap_level > 0 > Yes, I am studying if the setting of skb->encapsulation = 1 was really needed in the : if (tunnel) { skb_reset_inner_headers(skb); skb->encapsulation = 1; } And was planning to rename 'bool tunnel' by 'bool stacked' or something... > Eric's fix brings back performance for vxlan and gre keeps working. Thx! Please note the original performance is not that good, you mentioned 230 Mbps on lxc, while I get more than 5Gb/s on a 10G link. This should be investigated ... > > net/core/skbuff.c:3474 skb_try_coalesce() warning, I mentioned before, > is unrelated. > I still see it with this patch. Running either gre or vxlan tunnels. I think this might be related to commit 6ff50cd55545 ("tcp: gso: do not generate out of order packets") I'll investigate this as well, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists