netdev - Re: 16% regression on 10G caused by TCP small queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131027.010733.172184644367096185.davem@davemloft.net>
Date:	Sun, 27 Oct 2013 01:07:33 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dave.taht@...ferbloat.net
Cc:	stephen@...workplumber.org, ncardwell@...gle.com,
	eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: 16% regression on 10G caused by TCP small queues

From: Dave Taht <dave.taht@...ferbloat.net>
Date: Sat, 26 Oct 2013 21:33:52 -0700

> On Thu, Oct 24, 2013 at 03:01:21AM -0400, David Miller wrote:
>> From: Stephen Hemminger <stephen@...workplumber.org>
>> Date: Wed, 23 Oct 2013 21:45:57 -0700
>> 
>> > Sorry, thought sk_pacing_rate depended on FQ qdisc but it is other way around.
>> > In which case doing merge of these two was sufficient to fix the problem.
>> > With a minor manual fix up to tcp.h.
>> 
>> I know, I already have a half-built tree of -stable submissions
>> that does exactlty this.
> 
> I know that the "fq" qdisc is not exactly a -stable thing, but if it's simpler
> to include it rather than sort through the patch sets, I'm all for it.

I'm not including 'fq' and it's absolutely not necessary to fix this
bug.

'fq' is only incidentary to this bug fix because it just so happens to
make use of sk->sk_pacing_rate.  There is no other connection between
these two things.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html