netdev - Re: [PATCH net-next] WD80x3: fix printk() calls to netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131029.000058.328421771419196069.davem@davemloft.net>
Date:	Tue, 29 Oct 2013 00:00:58 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	quantumdude836@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] WD80x3: fix printk() calls to netdev_*() calls

From: Drew McGowen <quantumdude836@...il.com>
Date: Fri, 25 Oct 2013 21:56:05 +0000

> -	printk("%s: WD80x3 at %#3x, %pM",
> -	       dev->name, ioaddr, dev->dev_addr);
> +	netdev_info(dev, "WD80x3 at %#3x, %pM",
> +		ioaddr, dev->dev_addr);

This is incorrect indentation.

On a multi-line function call, the arguments one the second and subsequent
lines must start at exactly the first column after the openning parenthesis
on the first line.

Everyone who makes this mistake is trying to be lazy and use only TAB
characters to indent their code, don't do this.  You must use the
appropriate number of TAB _and_ SPACE characters necessary to achieve
the correct indentation.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html