netdev - Re: [PATCH net-next] 3c515: Fix warning when building

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131029.000316.767189982282205506.davem@davemloft.net>
Date:	Tue, 29 Oct 2013 00:03:16 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ricec2@....edu
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] 3c515: Fix warning when building

From: Colin Rice <ricec2@....edu>
Date: Fri, 25 Oct 2013 21:59:46 +0000

> -		outl((int) (skb->data), ioaddr + Wn7_MasterAddr);
> +		outl((size_t) (skb->data), ioaddr + Wn7_MasterAddr);

outl() takes an "int" not a "size_t".   You're avoiding the warning,
but on 64-bit, for example, you're silently allowing the compiler
to accept chopping off the top 32-bits of the 64-bit pointer address
off.

The warning is valid, this code won't work in certain environments,
and killing the warning is just papering over the problem such that
it will never get addressed properly.

I'm not applying patches like this, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html