netdev - Re: [PATCH net V3] xen-netback: use jiffies_64 value to calculate credit timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131029.002517.1798687875318867376.davem@davemloft.net>
Date:	Tue, 29 Oct 2013 00:25:17 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	wei.liu2@...rix.com
Cc:	xen-devel@...ts.xen.org, netdev@...r.kernel.org,
	david.vrabel@...rix.com, jbeulich@...e.com, annie.li@...cle.com,
	ian.campbell@...rix.com, jianhai.luan@...cle.com
Subject: Re: [PATCH net V3] xen-netback: use jiffies_64 value to calculate
 credit timeout

From: Wei Liu <wei.liu2@...rix.com>
Date: Mon, 28 Oct 2013 12:07:57 +0000

> time_after_eq() only works if the delta is < MAX_ULONG/2.
> 
> For a 32bit Dom0, if netfront sends packets at a very low rate, the time
> between subsequent calls to tx_credit_exceeded() may exceed MAX_ULONG/2
> and the test for timer_after_eq() will be incorrect. Credit will not be
> replenished and the guest may become unable to send packets (e.g., if
> prior to the long gap, all credit was exhausted).
> 
> Use jiffies_64 variant to mitigate this problem for 32bit Dom0.
> 
> Suggested-by: Jan Beulich <jbeulich@...e.com>
> Signed-off-by: Wei Liu <wei.liu2@...rix.com>
> Reviewed-by: David Vrabel <david.vrabel@...rix.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html