netdev - RE: [PATCH net-next] tipc: remove two indentation levels in tipc_recv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B73BC@saturn3.aculab.com>
Date:	Tue, 29 Oct 2013 11:13:09 -0000
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Ying Xue" <ying.xue@...driver.com>, <davem@...emloft.net>,
	<maloy@...jonn.com>
Cc:	<Paul.Gortmaker@...driver.com>, <jon.maloy@...csson.com>,
	<erik.hugne@...csson.com>, <tipc-discussion@...ts.sourceforge.net>,
	<netdev@...r.kernel.org>
Subject: RE: [PATCH net-next] tipc: remove two indentation levels in tipc_recv_msg routine

> The message dispatching part of tipc_recv_msg() is wrapped layers of
> while/if/if/switch, causing out-of-control indentation and does not
> look very good. We reduce two indentation levels by separating the
> message dispatching from the blocks that checks link state and
> sequence numbers, allowing longer function and arg names to be
> consistently indented without wrapping. This is a cosmetic change
> that does not alter the operation of TIPC in any way.
...
> +			tipc_node_unlock(n_ptr);
> +			goto cont;
> +		}
...
>		continue;
>  cont:
>  		kfree_skb(buf);
>  	}

I can only see one 'goto cont', an explicit kfree_skb() and
continue would be clearer.

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html