netdev - Re: [PATCH net-next] tipc: remove two indentation levels in tipc_recv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131029120708.GI14038@eerihug-hybrid.rnd.ki.sw.ericsson.se>
Date:	Tue, 29 Oct 2013 13:07:08 +0100
From:	Erik Hugne <erik.hugne@...csson.com>
To:	David Laight <David.Laight@...LAB.COM>
CC:	Ying Xue <ying.xue@...driver.com>, <davem@...emloft.net>,
	<maloy@...jonn.com>, <Paul.Gortmaker@...driver.com>,
	<jon.maloy@...csson.com>, <tipc-discussion@...ts.sourceforge.net>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] tipc: remove two indentation levels in
 tipc_recv_msg routine

On Tue, Oct 29, 2013 at 11:13:09AM +0000, David Laight wrote:
> I can only see one 'goto cont', an explicit kfree_skb() and
> continue would be clearer.

There's actually a few more 'goto cont' in the early error checks
in this function causes it to bail early. Those are not visible
in the patchdiff however.

//E
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html