lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 01 Nov 2013 17:56:38 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: Vijay Subramanian <subramanian.vijay@...il.com> Cc: netdev@...r.kernel.org, davem@...emloft.net, shemminger@...tta.com, Mythili Prabhu <mysuryan@...co.com>, Dave Taht <dave.taht@...ferbloat.net> Subject: Re: [PATCH v3 net-next] net: pkt_sched: PIE AQM scheme On Fri, 2013-11-01 at 13:45 -0700, Vijay Subramanian wrote: > + > + if (!drop_early(sch, skb->len)) { > + /* we can enqueue the packet */ > + q->stats.packets_in++; > + > + if (qdisc_qlen(sch) > q->stats.maxq) > + q->stats.maxq = qdisc_qlen(sch); > + > + return qdisc_enqueue_tail(skb, sch); I am not sure why you mix skb->len and qdisc_len(skb) Also, a default 200 packets limit sounds strange, was it actually tested on a 10Gb link ? Other than that, patch seems fine, thanks ! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists