netdev - Re: [PATCH v3 net-next] net: pkt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGK4HS-3r77+dk=k78WFC_ppg3cTgR+MwwDX2+Uuqrwb2K_V5w@mail.gmail.com>
Date:	Sat, 2 Nov 2013 22:38:03 -0700
From:	Vijay Subramanian <subramanian.vijay@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Stephen Hemminger <shemminger@...tta.com>,
	Mythili Prabhu <mysuryan@...co.com>,
	Dave Taht <dave.taht@...ferbloat.net>
Subject: Re: [PATCH v3 net-next] net: pkt_sched: PIE AQM scheme

Thanks for the reviews, Eric.

>> +
>> +             return qdisc_enqueue_tail(skb, sch);
>
> I am not sure why you mix skb->len and qdisc_len(skb)

I will refactor the code to update the stats more cleanly.

>
> Also, a default 200 packets limit sounds strange, was it actually tested
> on a 10Gb link ?
>
No. It was tested on 1 Gbps link. Increasing limit to a default of
1000 should be fine.
I will send v4 after some tests to make sure nothing breaks.

Thanks,
Vijay
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html