netdev - Re: [PATCH net-next v2 2/4] ipv6: enable IPV6_FLOWLABEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131105162225.GI8832@order.stressinduktion.org>
Date:	Tue, 5 Nov 2013 17:22:25 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Florent Fourcot <florent.fourcot@...t-bretagne.fr>,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/4] ipv6: enable IPV6_FLOWLABEL_MGR for getsockopt

On Tue, Nov 05, 2013 at 05:08:38PM +0100, Hannes Frederic Sowa wrote:
> On Tue, Nov 05, 2013 at 03:28:56PM +0100, Florent Fourcot wrote:
> > +	spin_lock_bh(&ip6_fl_lock);
> > +	rcu_read_lock_bh();
> > +
> > +	for_each_sk_fl_rcu(np, sfl) {
> > +		if (sfl->fl->label == (np->flow_label & IPV6_FLOWLABEL_MASK)) {
> 
> The iteration is protected by rcu, so need to take the ip6_fl_lock. We should
                                        ^no                         ^ here.

Sorry,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html