netdev - Re: [PATCH net-next] 8390 : Replace ei_debug with msg_enable/NETIF_MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1383860994.9263.31.camel@joe-AO722>
Date:	Thu, 07 Nov 2013 13:49:54 -0800
From:	Joe Perches <joe@...ches.com>
To:	Matthew Whitehead <tedheadster@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] 8390 : Replace ei_debug with
 msg_enable/NETIF_MSG_* feature

On Thu, 2013-11-07 at 16:42 -0500, Matthew Whitehead wrote:
> On Wed, Nov 06, 2013 at 03:49:13PM -0800, Joe Perches wrote:
> > On Wed, 2013-11-06 at 15:56 -0500, Matthew Whitehead wrote:
> > > Removed the shared ei_debug variable. Replaced it by adding u32 msg_enable to
> > > the private struct ei_device. Now each 8390 ethernet instance has a per-device
> > > logging variable.
> > > 
> > > Changed printk() calls to netdev_(dbg|info|warn|err) when possible.
> > 
> > Hello Matthew.
> > 
> > Ideally, some of these would use:
> > 
> > 	netif_<level>(struct ei_device *, type, struct net_device *, fmt, ...)
> > 
> > > @@ -352,10 +360,12 @@ static void
> > []
> > > +    if (ei_local->msg_enable & NETIF_MSG_HW)
> > > +		netdev_dbg(dev, "resetting the 8390 t=%ld...\n", jiffies);
> > 
> > 	netif_dbg(ei_local, hw, dev, "resetting the 8390 t=%...\n", jiffies);
> > 
> 
> Joe,

Hi Matthew

> what about using netif_msg_(drv|probe|ifdown|rx_err|tx_err|tx_queued|intr|rx_status|hw) calls?
> For example:
> 
> if (netif_msg_rx_err(ei_local))
>         netdev_err(dev, "Couldn't allocate a sk_buff of size %d\n", pkt_len);

I think that's OK if/when there are multiple statements
in a block after the netif_msg_<type> like:

	if (netif_msg_rx_err(ei_local)) {
		foo();
		bar();
	}

> I did a V2 in this style, but I'll change it to
> 
> netif_<level>(struct ei_device *, type, struct net_device *, fmt, ...)
> 
> if that is the more preferred style

Otherwise I think netif_<level> is the "more preferred" style.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html