netdev - Re: [PATCH net-next] 8390 : Replace ei_debug with msg_enable/NETIF_MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131107215543.GA28687@mwhitehe.csb>
Date:	Thu, 7 Nov 2013 16:55:43 -0500
From:	Matthew Whitehead <tedheadster@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] 8390 : Replace ei_debug with
 msg_enable/NETIF_MSG_* feature

> I think that's OK if/when there are multiple statements
> in a block after the netif_msg_<type> like:
> 
> 	if (netif_msg_rx_err(ei_local)) {
> 		foo();
> 		bar();
> 	}
> 
> > I did a V2 in this style, but I'll change it to
> > 
> > netif_<level>(struct ei_device *, type, struct net_device *, fmt, ...)
> > 
> > if that is the more preferred style
> 
> Otherwise I think netif_<level> is the "more preferred" style.
> 
> 
Joe,
  I'll do another version using netif_<level> and post it as V2.

- Matthew

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html