netdev - Re: [PATCH net-next v3 1/2] net_sched: fix some checkpatch errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131107.191945.629524953531140070.davem@davemloft.net>
Date:	Thu, 07 Nov 2013 19:19:45 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	yangyingliang@...wei.com
Cc:	netdev@...r.kernel.org, jhs@...atatu.com,
	stephen@...workplumber.org, dborkman@...hat.com
Subject: Re: [PATCH net-next v3 1/2] net_sched: fix some checkpatch errors

From: Yang Yingliang <yangyingliang@...wei.com>
Date: Thu, 7 Nov 2013 17:51:57 +0800

> -			if (cl->quantum <= 0 || cl->quantum>32*qdisc_dev(cl->qdisc)->mtu) {
> +			if (cl->quantum <= 0 ||
> +				cl->quantum > 32*qdisc_dev(cl->qdisc)->mtu) {

Still not indented properly.

The first character on the second line _MUST_ line up with the first column
after the openning parenthesis of the if() statement.  If you are just
using TAB characters to ident, you are doing it wrong.  You must use
the correct number of TAB and SPACE characters to reach the goal
column.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html