netdev - Re: [PATCH net-next v3 1/2] net_sched: fix some checkpatch errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <527C4418.8010207@huawei.com>
Date:	Fri, 8 Nov 2013 09:53:28 +0800
From:	Yang Yingliang <yangyingliang@...wei.com>
To:	David Miller <davem@...emloft.net>
CC:	<netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v3 1/2] net_sched: fix some checkpatch errors

On 2013/11/8 8:19, David Miller wrote:
> From: Yang Yingliang <yangyingliang@...wei.com>
> Date: Thu, 7 Nov 2013 17:51:57 +0800
> 
>> -			if (cl->quantum <= 0 || cl->quantum>32*qdisc_dev(cl->qdisc)->mtu) {
>> +			if (cl->quantum <= 0 ||
>> +				cl->quantum > 32*qdisc_dev(cl->qdisc)->mtu) {
> 
> Still not indented properly.
> 
> The first character on the second line _MUST_ line up with the first column
> after the openning parenthesis of the if() statement.  If you are just
> using TAB characters to ident, you are doing it wrong.  You must use
> the correct number of TAB and SPACE characters to reach the goal
> column.

Ok, i will fix it in v4.
Thanks

> 
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html