netdev - RE: [PATCH] USBNET: fix handling padding packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 Nov 2013 14:26:13 -0000
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Ming Lei" <ming.lei@...onical.com>,
	Bjørn Mork <bjorn@...k.no>
Cc:	"Oliver Neukum" <oneukum@...e.de>,
	"David S. Miller" <davem@...emloft.net>,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	"Network Development" <netdev@...r.kernel.org>,
	"linux-usb" <linux-usb@...r.kernel.org>
Subject: RE: [PATCH] USBNET: fix handling padding packet

> As my below test on ax99179_178a, I believe the patch should fix padding
> for dma sg, but need a little update, and I will send out v1 later:
> 
>            $ping -s 974 another_machine  #from host with ax99179_178a attached
> 
> If FLAG_SEND_ZLP is set for ax99179_178a, the above ping won't work any
> more either on USB3.0 or USB 2.0 host controller.
> 
> So don't assume that these brand new devices can support ZLP well.

I've just posted a fix to the xhci driver to implement URB_ZERO_PACKET.
With that fix (and ZLP enabled in the ax88179_178a driver) the above
ping works fine (ax88179 Ge card on USB3).

I wonder how many other usb drivers fail to support URB_ZERO_PACKET.
Maybe the driver should pass a flag to its users (along with SG support).

I've also posted (to linux-usb) another fix to the xhci driver that is
needed to get SG (and one that cross 64k boundaries) transfers working.

	David

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html