netdev - Re: [PATCH] net/7990: Make lance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Nov 2013 03:04:15 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
CC:	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Linux/m68k <linux-m68k@...r.kernel.org>
Subject: Re: [PATCH] net/7990: Make lance_private.name const

On 11/13/2013 01:44 AM, Geert Uytterhoeven wrote:

>>>>> @@ -100,7 +100,7 @@ struct lance_init_block {
>>>>>      */
>>>>>     struct lance_private
>>>>>     {
>>>>> -        char *name;
>>>>> +        const char *name;

>>>>      Indent with tab, not spaces, please.

>>> This whole file is %99 space indentation, you really can't blame
>>> Geert for this.

>>     It's never late to fix some.

> That would be a separate patch. Care to create and send it?

    I wasn't telling you to fix all of them, just the ones you touched anyway. 
I don't see why the separate patch is needed for that.

>> And remember about checkpatch.pl which was hardly content with the patch.

> Only because checkpatch looks at the _new_ lines, and doesn't compare the
> styles of the old and new lines.

    Care to fix it? :-)

> Gr{oetje,eeting}s,

>                          Geert

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html