netdev - Re: [PATCH net] core/dev: do not ignore dmac in dev_forward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131112052531.GB22272@private.email.ne.jp>
Date:	Tue, 12 Nov 2013 14:25:31 +0900
From:	Isaku Yamahata <yamahatanetdev@...il.com>
To:	Alexei Starovoitov <ast@...mgrid.com>
Cc:	Maciej Żenczykowski <zenczykowski@...il.com>,
	isaku.yamahata@...il.com, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Linux NetDev <netdev@...r.kernel.org>,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>,
	yamahatanetdev@...il.com
Subject: Re: [PATCH net] core/dev: do not ignore dmac in dev_forward_skb()

On Mon, Nov 11, 2013 at 05:12:10PM -0800,
Alexei Starovoitov <ast@...mgrid.com> wrote:

> On Mon, Nov 11, 2013 at 4:39 PM, Maciej Żenczykowski
> <zenczykowski@...il.com> wrote:
> > Ack.
> >
> > I'm sure this breaks whatever the original commit was trying to 'fix',
> > however it does so in a clearly incorrect manner by effectively
> > disabling dst mac address filtering.
> 
> actually it doesn't break it. Isaku's testcase works for me.

The changeset of 963a88b31ddbbe99f38502239b1a46601773d217
  "tunnels: harmonize cleanup done on skb on xmit path"
addresses the issue by calling skb_scrub_packet() when sending skb
through tunnel. So it is safe to revert it.

thanks,
-- 
Isaku Yamahata <isaku.yamahata@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html