netdev - Re: [PATCH] net:fec: fix WARNING caused by lack of calls to dma_mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1384395141.29151.23.camel@bwh-desktop.uk.level5networks.com>
Date:	Thu, 14 Nov 2013 02:12:21 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Fugang Duan <B38611@...escale.com>
CC:	<davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] net:fec: fix WARNING caused by lack of calls to
 dma_mapping_error()

On Thu, 2013-11-14 at 09:30 +0800, Fugang Duan wrote:
[...]
> =============================================
> V2: add net_ratelimit() to limit map err message.
>     use dma_sync_single_for_cpu() instead of dma_map_single().
>     fix the issue that pass DMA addresses to __va() to get virture address.
> V1: initial send
> =============================================
> 
> Signed-off-by: Fugang Duan <B38611@...escale.com>
> Reviewed-by: Ben Hutchings <ben@...adent.org.uk>
[...]

I'm sorry if I wasn't clear in my previous mail.  The 'Reviewed-by' tag
means someone has reviewed *this version* of the patch and explicitly
said it was good, usually by writing that tag in their reply.  You must
not add it just because someone reviewed and commented on an earlier
version of the patch.

I am not familiar with this driver or hardware so I would have to spend
some time looking at the surrounding code before being sure that it's
OK.  I can't spare that time, and so I don't claim to have given this
patch a full review.  But that's OK as you don't need my approval for
David to apply the patch. :-)

Please re-post without any reference to me.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html