netdev - RE: [PATCH] net:fec: fix WARNING caused by lack of calls to dma_mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9848F2DB572E5649BA045B288BE08FBE01815C73@039-SN2MPN1-023.039d.mgd.msft.net>
Date:	Thu, 14 Nov 2013 02:15:16 +0000
From:	Fugang Duan <fugang.duan@...escale.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] net:fec: fix WARNING caused by lack of calls to
 dma_mapping_error()

From: Ben Hutchings [mailto:bhutchings@...arflare.com]
Data: Thursday, November 14, 2013 10:12 AM

>To: Duan Fugang-B38611
>Cc: davem@...emloft.net; netdev@...r.kernel.org
>Subject: Re: [PATCH] net:fec: fix WARNING caused by lack of calls to
>dma_mapping_error()
>
>On Thu, 2013-11-14 at 09:30 +0800, Fugang Duan wrote:
>[...]
>> =============================================
>> V2: add net_ratelimit() to limit map err message.
>>     use dma_sync_single_for_cpu() instead of dma_map_single().
>>     fix the issue that pass DMA addresses to __va() to get virture address.
>> V1: initial send
>> =============================================
>>
>> Signed-off-by: Fugang Duan <B38611@...escale.com>
>> Reviewed-by: Ben Hutchings <ben@...adent.org.uk>
>[...]
>
>I'm sorry if I wasn't clear in my previous mail.  The 'Reviewed-by' tag means
>someone has reviewed *this version* of the patch and explicitly said it was
>good, usually by writing that tag in their reply.  You must not add it just
>because someone reviewed and commented on an earlier version of the patch.
>
>I am not familiar with this driver or hardware so I would have to spend some
>time looking at the surrounding code before being sure that it's OK.  I can't
>spare that time, and so I don't claim to have given this patch a full review.
>But that's OK as you don't need my approval for David to apply the patch. :-)
>
>Please re-post without any reference to me.
>
>Ben.

Ok, I know. Thanks for your detail info to explain it again.