[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20131114.163207.230147902479371528.davem@davemloft.net>
Date: Thu, 14 Nov 2013 16:32:07 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: zonque@...il.com
Cc: netdev@...r.kernel.org, marek.belisko@...il.com,
ujhelyi.m@...il.com
Subject: Re: [PATCH 1/2] net: phylib: add adjust_state callback to phy
device
From: Daniel Mack <zonque@...il.com>
Date: Wed, 13 Nov 2013 22:07:49 +0100
> Allow phy drivers to take action when the core does its link adjustment.
> No change for drivers that do not implement this callback.
>
> Signed-off-by: Daniel Mack <zonque@...il.com>
So you're using this to reset the entire PHY via the reset bit in the
BMCR register when the link goes down.
But this is going to break things.
If the phy library previously programmed a non-autonegotiated static
link configuration into the BMCR register, your reset is going to
undo that.
Now the configuration phylib thinks the chip has and the one it
acutally does is out of sync.
I'm not applying these patches, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists