netdev - Re: [PATCH] ipv4: fix possible seqlock deadlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1384465970.28716.44.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 14 Nov 2013 13:52:50 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Dave Jones <davej@...hat.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] ipv4: fix possible seqlock deadlock

On Thu, 2013-11-14 at 16:44 -0500, Dave Jones wrote:
> On Thu, Nov 14, 2013 at 01:37:54PM -0800, Eric Dumazet wrote:
>  > From: Eric Dumazet <edumazet@...gle.com>
>  > 
>  > ip4_datagram_connect() being called from process context,
>  > it should use IP_INC_STATS() instead of IP_INC_STATS_BH()
>  > otherwise we can deadlock on 32bit arches, or get corruptions of
>  > SNMP counters.
>  > 
>  > Fixes: 584bdf8cbdf6 ("[IPV4]: Fix "ipOutNoRoutes" counter error for TCP and UDP")
> 
> whoa, 2007. Any idea why I only just started hitting this ?
> 

lockdep support was added very recently.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html